fleetd #726: name RELAUNCH_NEVER_READY in the IN_PROGRESS terminal-state list
The javadoc on RollState.IN_PROGRESS enumerates the terminal states the entry can be overwritten with, and omitted RELAUNCH_NEVER_READY. That state is reachable at LeadRollover.java:710, so the list told a reader a state could not occur when it can. Found by a reviewer on PR #742, outside its assigned scope. Comment only; no behaviour change.
This commit is contained in:
@@ -248,9 +248,9 @@ public final class LeadRollover {
|
||||
* that is, in fact, actively running. This is not sticky: the deferred continuation
|
||||
* overwrites this same entry with a terminal state ({@link #ROLLED}, {@link
|
||||
* #TURN_NEVER_SETTLED}, {@link #OLD_PANE_NEVER_DIED}, {@link #RELAUNCH_FAILED}, {@link
|
||||
* #RELAUNCH_NOT_RECOGNISED}, or {@link #FAILED}) once it finishes — including by throwing,
|
||||
* which {@link #runRollover}'s catch turns into {@link #FAILED} instead of leaving this
|
||||
* entry stuck forever.
|
||||
* #RELAUNCH_NEVER_READY}, {@link #RELAUNCH_NOT_RECOGNISED}, or {@link #FAILED}) once it
|
||||
* finishes — including by throwing, which {@link #runRollover}'s catch turns into {@link
|
||||
* #FAILED} instead of leaving this entry stuck forever.
|
||||
*/
|
||||
IN_PROGRESS,
|
||||
/**
|
||||
|
||||
Reference in New Issue
Block a user