From 9d653e86dff9f061ebcdc72bdc104f3a34494624 Mon Sep 17 00:00:00 2001 From: Dai Ha Date: Sun, 4 Oct 2026 21:44:03 +0200 Subject: [PATCH] fleetd #726: name RELAUNCH_NEVER_READY in the IN_PROGRESS terminal-state list The javadoc on RollState.IN_PROGRESS enumerates the terminal states the entry can be overwritten with, and omitted RELAUNCH_NEVER_READY. That state is reachable at LeadRollover.java:710, so the list told a reader a state could not occur when it can. Found by a reviewer on PR #742, outside its assigned scope. Comment only; no behaviour change. --- fleetd/src/main/java/dev/ltms/fleet/lead/LeadRollover.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fleetd/src/main/java/dev/ltms/fleet/lead/LeadRollover.java b/fleetd/src/main/java/dev/ltms/fleet/lead/LeadRollover.java index 3c6c784..daeabda 100644 --- a/fleetd/src/main/java/dev/ltms/fleet/lead/LeadRollover.java +++ b/fleetd/src/main/java/dev/ltms/fleet/lead/LeadRollover.java @@ -248,9 +248,9 @@ public final class LeadRollover { * that is, in fact, actively running. This is not sticky: the deferred continuation * overwrites this same entry with a terminal state ({@link #ROLLED}, {@link * #TURN_NEVER_SETTLED}, {@link #OLD_PANE_NEVER_DIED}, {@link #RELAUNCH_FAILED}, {@link - * #RELAUNCH_NOT_RECOGNISED}, or {@link #FAILED}) once it finishes — including by throwing, - * which {@link #runRollover}'s catch turns into {@link #FAILED} instead of leaving this - * entry stuck forever. + * #RELAUNCH_NEVER_READY}, {@link #RELAUNCH_NOT_RECOGNISED}, or {@link #FAILED}) once it + * finishes — including by throwing, which {@link #runRollover}'s catch turns into {@link + * #FAILED} instead of leaving this entry stuck forever. */ IN_PROGRESS, /**