Dai Ha
2e138a199b
Two changes ship together here.
1. One shared herdr workspace. The lead and every worker now live in one
workspace called "fleet", so the operator sees one "session" with many
windows, not two. Before, the lead sat in a "leads" workspace and workers
in "bridged-workers", which read as two sessions. The lead is still told
apart from workers by its exact tab label ("lead: <name>"), so putting them
in one space is safe. LeadTabScanner keeps the exclude-by-label mechanism
for split layouts; Fleetd now passes an empty exclude set.
2. Rename the daemon from "bridged" to "fleetd" (the binary, config, scripts,
launchd/systemd units, module dir, and MCP mount).
- Module dir bridged/ -> fleetd/; jar finalName -> fleetd.jar.
- Log line, comments, docs, and CLAUDE.md updated to say fleetd.
- Scripts renamed: redeploy-bridged.sh -> redeploy-fleetd.sh,
bridged-launchd-wrapper.sh -> fleetd-launchd-wrapper.sh.
- Deploy units renamed: dev.ltms.bridged.plist -> dev.ltms.fleetd.plist,
bridged.service -> fleetd.service; launchd Label -> dev.ltms.fleetd.
- Config default bridged.yaml -> fleetd.yaml; the legacy bridged.yaml is
still read as a fallback, and still gitignored.
- MCP: drop the deprecated bridge_* tool twins; only fleet_* remain. The
server name is "fleet". The mount name in the local .mcp.json becomes
"fleet" (gitignored, not in this commit).
- Env var defaults BRIDGED_API_TOKEN -> FLEETD_API_TOKEN, fixture
BRIDGED_WORKER_TOKEN -> FLEETD_WORKER_TOKEN.
Kept on purpose: the BRIDGED_MEMBER marker. Renaming it is a coupled change to
the credential-scrub security control (an operator secrets.sh may guard on it),
so it stays until that migration is done on its own.
Metrics were already fleet_* (CB-632); MetricNamesTest still guards that no
name says bridged_.
The canonical CLAUDE.md block and the wiki template stay byte-identical
(wiki working tree edited, committed to the wiki repo separately).
949 tests pass (mvn clean install). 4 fewer than before = the 4 removed
bridge_* alias tests.
35 lines
1.4 KiB
Markdown
35 lines
1.4 KiB
Markdown
---
|
|
description: Review one assigned scope and report the most important real issue.
|
|
mode: primary
|
|
---
|
|
|
|
<!-- CB-617: The model comes from fleetd.yaml because the launch flag overrides model here on both backends. -->
|
|
|
|
You review the diff you were given. Report bugs, risks, and missing tests. You do
|
|
not change code.
|
|
|
|
Read the whole assigned scope before judging it. Review only that scope. If you see
|
|
something outside it, note it in one line and do not investigate it further. Do not
|
|
run the build. The owner makes changes and runs checks.
|
|
|
|
Use `fleet_ask{question}` only when a decision belongs to the lead, such as an
|
|
unclear requirement or two defensible fixes. Do not ask about something you can
|
|
decide by reading more code.
|
|
|
|
Report the single most important real issue in this form:
|
|
|
|
```
|
|
1. <path>:<line>
|
|
2. issue: <one sentence: what is wrong and why it matters>
|
|
3. fix: <one line: the concrete change>
|
|
4. severity: high | medium | low
|
|
```
|
|
|
|
If there is no real issue, report `NO ISSUE` and one line saying why. A clean review
|
|
is valid. Do not invent an issue. Use high for a wrong result, data loss, security,
|
|
or a hang or crash on a real path. Use medium for an edge-path bug or a correctness
|
|
risk under load or concurrency. Use low for clarity, a latent foot-gun, or a smell
|
|
with no current failure.
|
|
|
|
The launcher provides the required bridge reply instructions for every member.
|