fleet/fleetd
3
0
Fork 0
Code Issues 73 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

CB-520: split ReplyInbox into explicit own/release and publish halves #9

Closed
ltms wants to merge 1 commits from worker/cb-520-inbox-produce-consume-split-825963-3 into main
pull from: worker/cb-520-inbox-produce-consume-split-825963-3
merge into: fleet:main
Conversation 0 Commits 1 Files Changed 11
+270 -60
ltms commented 2026-08-04 17:56:02 +02:00
Owner
Copy Link
Copy Source

Splits the reply inbox port so publishing no longer implies consuming/owning.

  • ReplyInbox gains explicit own(target) / release(target) lifecycle methods.
  • InMemoryReplyInbox enforces ownership: peek/ack only operate on owned targets; publish works for any target.
  • AmqpReplyInbox only attaches a manual-ack consumer on own; publish sends to the queue without consuming.
  • SessionManager now notifies acquire listeners; Bridged wires replyInbox.own on acquire and replyInbox.release on release.
  • Tests updated to own targets before draining; contract test updated and adds coverage proving publish does not attach a consumer and that release cancels the consumer.

mvn clean install from bridged/: Tests run: 360, Failures: 0, Errors: 0, Skipped: 0.

The AMQP contract tests were updated but could not be executed here (Docker/testcontainers unavailable; excluded by default-excludes profile per CB-521).

Splits the reply inbox port so publishing no longer implies consuming/owning. - `ReplyInbox` gains explicit `own(target)` / `release(target)` lifecycle methods. - `InMemoryReplyInbox` enforces ownership: `peek`/`ack` only operate on owned targets; `publish` works for any target. - `AmqpReplyInbox` only attaches a manual-ack consumer on `own`; `publish` sends to the queue without consuming. - `SessionManager` now notifies acquire listeners; `Bridged` wires `replyInbox.own` on acquire and `replyInbox.release` on release. - Tests updated to own targets before draining; contract test updated and adds coverage proving publish does not attach a consumer and that release cancels the consumer. `mvn clean install` from `bridged/`: Tests run: 360, Failures: 0, Errors: 0, Skipped: 0. The AMQP contract tests were updated but could not be executed here (Docker/testcontainers unavailable; excluded by `default-excludes` profile per CB-521).
ltms added 1 commit 2026-08-04 17:56:03 +02:00
CB-520: split ReplyInbox into explicit own/release and publish halves
CI / build (pull_request) Successful in 1m22s
Details
f32f90ffb1
ltms closed this pull request 2026-08-13 16:01:32 +02:00
ltms deleted branch worker/cb-520-inbox-produce-consume-split-825963-3 2026-08-13 16:01:32 +02:00
Some checks are pending
CI / build (pull_request) Successful in 1m22s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Cannot start until something else lands. The body says what.
 needs-live-proof
Merged and green, but never shown working on the running daemon. Not the same as done.
 ready-to-delegate
Scope, files and acceptance criteria are written. A worker can be briefed from the body alone.
 silent-default
A feature that compiles, passes tests, and ships turned off. Nine recurrences and counting.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent kevin ltms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fleet/fleetd#9
Delete Branch "worker/cb-520-inbox-produce-consume-split-825963-3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?