fleet/fleetd
3
0
Fork 0
Code Issues 97 Pull Requests 3 Actions Packages Projects Releases 1 Wiki Activity

fleetd #771 step 1: report each pane's workspace label in fleet_list #772

Closed
agent wants to merge 0 commits from worker/771-e1dbc8-1 into main
pull from: worker/771-e1dbc8-1
merge into: fleet:main
Conversation 0 Commits - Files Changed -
agent commented 2026-10-05 11:37:55 +02:00
Member
Copy Link
Copy Source

Step 1 only of fleetd #771 -- steps 2-4 wait on a design decision.

Adds workspaceLabel next to workspaceId on fleet_list's full panes row, read via a new PaneLocator.workspaceLabelsByWorkspaceId() (mirrors tabLabelsByTabId, reuses the existing Workspace model type).

  • An observer's reduced panes row does NOT gain this field (pinned by listFiltersAndReducesThePanesArrayForAnObserver).
  • A herdr failure (workspace.list throws) yields workspaceLabel: null without costing leads/members/capacity/coordinator (pinned by listStillReportsEveryOtherArrayWhenTheLabelScanFails).
  • An unknown workspaceId (no entry in the lookup) also yields workspaceLabel: null without dropping the row (pinned by a new test, listReportsANullWorkspaceLabelForAnUnknownWorkspaceId).
  • No new package cycle: the new method lives in the existing herdr package, reusing Workspace.from().

mvn clean install: BUILD SUCCESS, Tests run: 2168, Failures: 0, Errors: 0, Skipped: 0.

Step 1 only of fleetd #771 -- steps 2-4 wait on a design decision. Adds workspaceLabel next to workspaceId on fleet_list's full panes row, read via a new PaneLocator.workspaceLabelsByWorkspaceId() (mirrors tabLabelsByTabId, reuses the existing Workspace model type). - An observer's reduced panes row does NOT gain this field (pinned by listFiltersAndReducesThePanesArrayForAnObserver). - A herdr failure (workspace.list throws) yields workspaceLabel: null without costing leads/members/capacity/coordinator (pinned by listStillReportsEveryOtherArrayWhenTheLabelScanFails). - An unknown workspaceId (no entry in the lookup) also yields workspaceLabel: null without dropping the row (pinned by a new test, listReportsANullWorkspaceLabelForAnUnknownWorkspaceId). - No new package cycle: the new method lives in the existing herdr package, reusing Workspace.from(). mvn clean install: BUILD SUCCESS, Tests run: 2168, Failures: 0, Errors: 0, Skipped: 0.
agent added 1 commit 2026-10-05 11:37:55 +02:00
fleetd #771 step 1: report each pane's workspace label in fleet_list
CI / shell-tests (pull_request) Failing after 8s
Details
CI / contract (pull_request) Successful in 53s
Details
CI / build (pull_request) Failing after 1m57s
Details
CI / shell-tests (push) Failing after 6s
Details
CI / contract (push) Successful in 54s
Details
CI / build (push) Failing after 1m50s
Details
364b229db9 
Adds workspaceLabel next to workspaceId on fleet_list's panes row, read
from herdr's workspace.list via a new PaneLocator.workspaceLabelsByWorkspaceId().
An observer's reduced row still excludes it; a herdr failure or an unknown
workspaceId yields workspaceLabel: null without costing the rest of fleet_list.
ltms closed this pull request 2026-10-05 11:41:28 +02:00
ltms deleted branch worker/771-e1dbc8-1 2026-10-05 11:41:28 +02:00
Some checks are pending
CI / shell-tests (pull_request) Failing after 8s
Details
CI / contract (pull_request) Successful in 53s
Details
CI / build (pull_request) Failing after 1m57s
Details
CI / shell-tests (push) Failing after 6s
Details
CI / contract (push) Successful in 54s
Details
CI / build (push) Failing after 1m50s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Cannot start until something else lands. The body says what.
 needs-live-proof
Merged and green, but never shown working on the running daemon. Not the same as done.
 ready-to-delegate
Scope, files and acceptance criteria are written. A worker can be briefed from the body alone.
 silent-default
A feature that compiles, passes tests, and ships turned off. Nine recurrences and counting.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent kevin ltms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fleet/fleetd#772
Delete Branch "worker/771-e1dbc8-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?