fleet/fleetd
3
0
Fork 0
Code Issues 73 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

CB-579: resolve a lead by its tab name, drop the terminal-id pin #55

Merged
ltms merged 1 commits from worker/cb579-lead-tab-acba06-20 into main 2026-08-15 09:29:01 +02:00
Conversation 0 Commits 1 Files Changed 9
+399 -236
ltms commented 2026-08-15 08:54:45 +02:00
Owner
Copy Link
Copy Source

Closes #51.

Opened by the lead on the worker's behalf: the sonnet profile has no gitTokenEnv until the
daemon restarts, so the member could commit and push but not open its own PR.

The member's own report was lost. It finished (BUSY -> DONE at 08:05) and I failed to poll it
before the idle reaper released it at 08:35. There was no bridge_reply and no completion scrape,
so there are no worker-supplied test counts or notes here — only the code. Review accordingly: this
PR has had no author write-up, and everything claimed below is from the lead reading the diff.

Branched from 2f48e08. Not yet verified or reviewed by the lead at the time of opening.

Closes #51. Opened by the lead on the worker's behalf: the `sonnet` profile has no `gitTokenEnv` until the daemon restarts, so the member could commit and push but not open its own PR. **The member's own report was lost.** It finished (`BUSY -> DONE` at 08:05) and I failed to poll it before the idle reaper released it at 08:35. There was no `bridge_reply` and no completion scrape, so there are no worker-supplied test counts or notes here — only the code. Review accordingly: this PR has had no author write-up, and everything claimed below is from the lead reading the diff. Branched from `2f48e08`. Not yet verified or reviewed by the lead at the time of opening.
ltms added 1 commit 2026-08-15 08:54:46 +02:00
CB-579: resolve a lead by its tab name, drop the terminal-id pin
CI / build (pull_request) Successful in 52s
Details
CI / contract (pull_request) Successful in 1m18s
Details
976eff8ad1 
Leader.terminal -> Leader.tab (exact tab label, case-insensitive match).
LeadTabScanner matches an exact tab->name map instead of stripping a
shared tabPrefix, and no longer merges configured leads into every
scan result -- a stale pin can no longer outlive its tab.
LeadLauncher.tabLabel() returns the configured tab directly; the
terminalId pinned-terminal fallback in liveLeads() is gone.
Config load now rejects a leftover fleet.leaders.*.terminal key
instead of silently ignoring it. primary.terminal is untouched.
ltms merged commit 42f46dfe9a into main 2026-08-15 09:29:01 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Cannot start until something else lands. The body says what.
 needs-live-proof
Merged and green, but never shown working on the running daemon. Not the same as done.
 ready-to-delegate
Scope, files and acceptance criteria are written. A worker can be briefed from the body alone.
 silent-default
A feature that compiles, passes tests, and ships turned off. Nine recurrences and counting.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent kevin ltms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fleet/fleetd#55
Delete Branch "worker/cb579-lead-tab-acba06-20"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?