fleet/fleetd
3
0
Fork 0
Code Issues 73 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

#455: document herdr test socket exception #461

Merged
ltms merged 1 commits from worker/455-herdr-addendum-8af51d-9 into main 2026-09-10 13:18:18 +02:00
Conversation 0 Commits 1 Files Changed 1
+13
agent commented 2026-09-10 13:14:13 +02:00
Member
Copy Link
Copy Source

Closes #455.

Change

Added the following project addendum note to CLAUDE.md:

Herdr socket tests (measured 2026-09-10). In this repo, herdr is a subject under test. A worker assigned to herdr code, and the lead, may let a test open the herdr socket directly in a throwaway workspace that the test tears down. This only covers fleetd/src/test/java/dev/ltms/fleet/herdr/AgentControlContractTest.java, fleetd/src/test/java/dev/ltms/fleet/herdr/HerdrContractTest.java, fleetd/src/test/java/dev/ltms/fleet/herdr/PaneLocatorContractTest.java, and fleetd/src/test/java/dev/ltms/fleet/herdr/WorkspacePlacementContractTest.java. It is not a general licence. Using the herdr CLI or socket to move a real fleet session, pane, or peer stays banned. That is the control plane that invariant 5 protects. Re-measure with grep -rl 'UnixSocketHerdrClient.connect()' fleetd/src/test/java --include='*.java'. A non-empty result means tests still open the socket and this note still applies. An empty result means nobody does this any more; delete this section. Canonical invariant 5 restatement is tracked in #458 and is not part of this change.

Checks

  • mvn clean install: [INFO] Tests run: 1578, Failures: 0, Errors: 0, Skipped: 0; [INFO] BUILD SUCCESS; exit=0.
  • git diff --stat before commit: CLAUDE.md | 13 +++++++++++++, 1 file changed, 13 insertions(+).
  • The required sync script could not run because the provisioned worktree has an uninitialized wiki submodule. It failed with FileNotFoundError: wiki/7-Use-Cases.md. git submodule status showed -d526b43c87fdea6c8b257e79917bcc4b8a49f582 wiki. I did not touch wiki/, as required.

Pre-send check

A worker assigned to AgentControlContractTest may let that test open the herdr socket directly in its throwaway workspace, then let the test tear it down.

Caveat: the canonical sync result is unavailable in this worktree because wiki/ is uninitialized.

Closes #455. ## Change Added the following project addendum note to `CLAUDE.md`: > **Herdr socket tests (measured 2026-09-10).** In this repo, herdr is a subject under test. A worker assigned to herdr code, and the lead, may let a test open the herdr socket directly in a throwaway workspace that the test tears down. This only covers `fleetd/src/test/java/dev/ltms/fleet/herdr/AgentControlContractTest.java`, `fleetd/src/test/java/dev/ltms/fleet/herdr/HerdrContractTest.java`, `fleetd/src/test/java/dev/ltms/fleet/herdr/PaneLocatorContractTest.java`, and `fleetd/src/test/java/dev/ltms/fleet/herdr/WorkspacePlacementContractTest.java`. It is not a general licence. Using the herdr CLI or socket to move a real fleet session, pane, or peer stays banned. That is the control plane that invariant 5 protects. Re-measure with `grep -rl 'UnixSocketHerdrClient.connect()' fleetd/src/test/java --include='*.java'`. A non-empty result means tests still open the socket and this note still applies. An empty result means nobody does this any more; delete this section. Canonical invariant 5 restatement is tracked in #458 and is not part of this change. ## Checks - `mvn clean install`: `[INFO] Tests run: 1578, Failures: 0, Errors: 0, Skipped: 0`; `[INFO] BUILD SUCCESS`; `exit=0`. - `git diff --stat` before commit: `CLAUDE.md | 13 +++++++++++++`, `1 file changed, 13 insertions(+)`. - The required sync script could not run because the provisioned worktree has an uninitialized `wiki` submodule. It failed with `FileNotFoundError: wiki/7-Use-Cases.md`. `git submodule status` showed `-d526b43c87fdea6c8b257e79917bcc4b8a49f582 wiki`. I did not touch `wiki/`, as required. ## Pre-send check A worker assigned to `AgentControlContractTest` may let that test open the herdr socket directly in its throwaway workspace, then let the test tear it down. Caveat: the canonical sync result is unavailable in this worktree because `wiki/` is uninitialized.
agent added 1 commit 2026-09-10 13:14:13 +02:00
#455: document herdr test socket exception
CI / contract (pull_request) Successful in 1m5s
Details
CI / build (pull_request) Successful in 1m50s
Details
bf027f10b9
ltms merged commit 9d1306d442 into main 2026-09-10 13:18:18 +02:00
ltms deleted branch worker/455-herdr-addendum-8af51d-9 2026-09-10 13:18:18 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Cannot start until something else lands. The body says what.
 needs-live-proof
Merged and green, but never shown working on the running daemon. Not the same as done.
 ready-to-delegate
Scope, files and acceptance criteria are written. A worker can be briefed from the body alone.
 silent-default
A feature that compiles, passes tests, and ships turned off. Nine recurrences and counting.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent kevin ltms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fleet/fleetd#461
Delete Branch "worker/455-herdr-addendum-8af51d-9"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?