fleet/fleetd
3
0
Fork 0
Code Issues 73 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fleetd #345: test timeout cancellation race #349

Closed
agent wants to merge 0 commits from worker/fd345-490d0f-3 into main
pull from: worker/fd345-490d0f-3
merge into: fleet:main
Conversation 0 Commits - Files Changed -
agent commented 2026-09-04 11:31:36 +02:00
Member
Copy Link
Copy Source

fleetd #345

Change

Uses mechanism 1: a package-private, test-only timeout hook in MessageService. The hook runs after the first incomplete completion read and before Injector.cancel takes the target monitor. This matches the existing race-hook pattern and tests the caller wiring against the real final Injector.

What the test does not prove

The test does not prove this exact interleaving occurs by itself under production timing. It forces the interleaving through the hook. It proves that the timeout caller uses Cancellation.DELIVERED when the interleaving occurs.

Mutation proof

I copied MessageService.java aside, replaced the assignment from injector.cancel with a bare injector.cancel(delivery); call, and ran the full suite. It failed as required: MessageServiceTest.sendTimeoutUsesCancellationDeliveredWhenPickupWinsTheRace at MessageServiceTest.java:429, expected TIMED_OUT_WORKING but was TIMED_OUT_QUEUED. Maven reported: Tests run: 1364, Failures: 1, Errors: 0, Skipped: 0 and BUILD FAILURE. I restored the production line.

Final check

Ran /Users/dai.ha/Softwares/apache-maven/bin/mvn clean install in fleetd without a pipe. Result: Tests run: 1364, Failures: 0, Errors: 0, Skipped: 0; BUILD SUCCESS.

Files changed:

  • fleetd/src/main/java/dev/ltms/fleet/msg/MessageService.java
  • fleetd/src/test/java/dev/ltms/fleet/msg/MessageServiceTest.java
## fleetd #345 ### Change Uses mechanism 1: a package-private, test-only timeout hook in MessageService. The hook runs after the first incomplete completion read and before Injector.cancel takes the target monitor. This matches the existing race-hook pattern and tests the caller wiring against the real final Injector. ### What the test does not prove The test does not prove this exact interleaving occurs by itself under production timing. It forces the interleaving through the hook. It proves that the timeout caller uses Cancellation.DELIVERED when the interleaving occurs. ### Mutation proof I copied MessageService.java aside, replaced the assignment from injector.cancel with a bare injector.cancel(delivery); call, and ran the full suite. It failed as required: MessageServiceTest.sendTimeoutUsesCancellationDeliveredWhenPickupWinsTheRace at MessageServiceTest.java:429, expected TIMED_OUT_WORKING but was TIMED_OUT_QUEUED. Maven reported: Tests run: 1364, Failures: 1, Errors: 0, Skipped: 0 and BUILD FAILURE. I restored the production line. ### Final check Ran /Users/dai.ha/Softwares/apache-maven/bin/mvn clean install in fleetd without a pipe. Result: Tests run: 1364, Failures: 0, Errors: 0, Skipped: 0; BUILD SUCCESS. Files changed: - fleetd/src/main/java/dev/ltms/fleet/msg/MessageService.java - fleetd/src/test/java/dev/ltms/fleet/msg/MessageServiceTest.java
agent added 1 commit 2026-09-04 11:31:37 +02:00
fleetd #345: test timeout cancellation race
CI / contract (pull_request) Successful in 1m28s
Details
CI / build (pull_request) Successful in 2m3s
Details
ea12107497
ltms closed this pull request 2026-09-04 11:35:49 +02:00
Some checks are pending
CI / contract (pull_request) Successful in 1m28s
Details
CI / build (pull_request) Successful in 2m3s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Cannot start until something else lands. The body says what.
 needs-live-proof
Merged and green, but never shown working on the running daemon. Not the same as done.
 ready-to-delegate
Scope, files and acceptance criteria are written. A worker can be briefed from the body alone.
 silent-default
A feature that compiles, passes tests, and ships turned off. Nine recurrences and counting.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent kevin ltms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fleet/fleetd#349
Delete Branch "worker/fd345-490d0f-3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?