fleet/fleetd
3
0
Fork 0
Code Issues 73 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

CB-562: log why the readiness gate gave up on a target #33

Closed
agent wants to merge 0 commits from worker/cb-562-readiness-gate-silent-6c23c9-3 into main
pull from: worker/cb-562-readiness-gate-silent-6c23c9-3
merge into: fleet:main
Conversation 1 Commits - Files Changed -
agent commented 2026-08-14 21:53:32 +02:00
Member
Copy Link
Copy Source

When the injector's readiness gate expires (the worker stayed idle-but-not-ready for the whole grace), it used to clear the queue and log nothing. The resulting failure surfaced elsewhere as a turn-stall fallback that names the wrong cause. This adds a WARN at grace expiry that carries the target id, the failed message count, and the derived grace duration in seconds, and states the real cause: the message never reached the pane.

No behaviour change: only an added log statement and a static constant used to derive the grace seconds (no new state, no timing change, same fail/release behaviour). The existing catch-and-set-sendError path already logs via the existing warn at Injector.java line ~340, so it was left alone.

Test: added readinessGraceExpiryIsLogged using the same logback ListAppender capture pattern as AuditLogTest, asserting the expiry WARN names the target and the real cause.

Verified: mvn clean install -> Tests run: 641, Failures: 0, Errors: 0, Skipped: 0, BUILD SUCCESS.

When the injector's readiness gate expires (the worker stayed idle-but-not-ready for the whole grace), it used to clear the queue and log nothing. The resulting failure surfaced elsewhere as a turn-stall fallback that names the wrong cause. This adds a WARN at grace expiry that carries the target id, the failed message count, and the derived grace duration in seconds, and states the real cause: the message never reached the pane. No behaviour change: only an added log statement and a static constant used to derive the grace seconds (no new state, no timing change, same fail/release behaviour). The existing catch-and-set-sendError path already logs via the existing warn at Injector.java line ~340, so it was left alone. Test: added readinessGraceExpiryIsLogged using the same logback ListAppender capture pattern as AuditLogTest, asserting the expiry WARN names the target and the real cause. Verified: mvn clean install -> Tests run: 641, Failures: 0, Errors: 0, Skipped: 0, BUILD SUCCESS.
agent added 1 commit 2026-08-14 21:53:32 +02:00
CB-562: log why the readiness gate gave up on a target
CI / build (pull_request) Successful in 57s
Details
CI / contract (pull_request) Successful in 1m4s
Details
7a583c4045
ltms added 1 commit 2026-08-15 04:20:32 +02:00
CB-562: single source for the injector poll cadence; tighten count assertion
CI / build (pull_request) Successful in 59s
Details
CI / contract (pull_request) Successful in 1m17s
Details
95e45007aa
ltms commented 2026-08-15 07:11:23 +02:00
Owner
Copy Link
Copy Source

Closing as landed. Verified with git cherry main <branch>: every commit's content is present in main. The branch tip is not an ancestor only because the commit was rebased before merge, so the SHA differs while the patch is identical. No code is lost. Verified 2026-08-15.

Closing as **landed**. Verified with `git cherry main <branch>`: every commit's content is present in `main`. The branch tip is not an ancestor only because the commit was rebased before merge, so the SHA differs while the patch is identical. No code is lost. Verified 2026-08-15.
ltms closed this pull request 2026-08-15 07:11:25 +02:00
Some checks are pending
CI / build (pull_request) Successful in 59s
Details
CI / contract (pull_request) Successful in 1m17s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Cannot start until something else lands. The body says what.
 needs-live-proof
Merged and green, but never shown working on the running daemon. Not the same as done.
 ready-to-delegate
Scope, files and acceptance criteria are written. A worker can be briefed from the body alone.
 silent-default
A feature that compiles, passes tests, and ships turned off. Nine recurrences and counting.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent kevin ltms
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fleet/fleetd#33
Delete Branch "worker/cb-562-readiness-gate-silent-6c23c9-3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?