fleet/fleetd
3
0
Fork 0
Code Issues 73 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fleetd #296: close panes on failed spawn #299

Closed
agent wants to merge 0 commits from worker/fix-296-104622-6 into main
pull from: worker/fix-296-104622-6
merge into: fleet:main
Conversation 0 Commits - Files Changed -
agent commented 2026-09-04 07:05:59 +02:00
Member
Copy Link
Copy Source

Exit A now closes the pane after an unrelated readiness-gate HerdrException, but rethrows that same exception unchanged. This is necessary because spawn throws before its caller gets the pane id.

Exit B now closes a split pane when agent.start fails. Both cleanups are best effort and log a WARN without masking the original error.

Tests: cd fleetd && mvn clean install passed: Tests run: 1304, Failures: 0, Errors: 0, Skipped: 0; BUILD SUCCESS. Targeted restored tests passed: Tests run: 2, Failures: 0, Errors: 0, Skipped: 0; BUILD SUCCESS.

Mutation proof: removing Exit A cleanup failed spawnLetsAnUnrelatedHerdrErrorPropagateUnchanged: expected: <1> but was: <0>. Removing Exit B cleanup failed panePlacementClosesTheSplitPaneWhenAgentStartFails: expected: <1> but was: <0>.

Shape check: inspected HerdrPeerLauncher spawn-side resource creation and exits. No other matching unguarded created-resource exit was found.

Changed files: fleetd/src/main/java/dev/ltms/fleet/member/HerdrPeerLauncher.java; fleetd/src/test/java/dev/ltms/fleet/herdr/FakeHerdr.java; fleetd/src/test/java/dev/ltms/fleet/member/ClaudeCodeLauncherTest.java.

Exit A now closes the pane after an unrelated readiness-gate HerdrException, but rethrows that same exception unchanged. This is necessary because spawn throws before its caller gets the pane id. Exit B now closes a split pane when agent.start fails. Both cleanups are best effort and log a WARN without masking the original error. Tests: cd fleetd && mvn clean install passed: Tests run: 1304, Failures: 0, Errors: 0, Skipped: 0; BUILD SUCCESS. Targeted restored tests passed: Tests run: 2, Failures: 0, Errors: 0, Skipped: 0; BUILD SUCCESS. Mutation proof: removing Exit A cleanup failed spawnLetsAnUnrelatedHerdrErrorPropagateUnchanged: expected: <1> but was: <0>. Removing Exit B cleanup failed panePlacementClosesTheSplitPaneWhenAgentStartFails: expected: <1> but was: <0>. Shape check: inspected HerdrPeerLauncher spawn-side resource creation and exits. No other matching unguarded created-resource exit was found. Changed files: fleetd/src/main/java/dev/ltms/fleet/member/HerdrPeerLauncher.java; fleetd/src/test/java/dev/ltms/fleet/herdr/FakeHerdr.java; fleetd/src/test/java/dev/ltms/fleet/member/ClaudeCodeLauncherTest.java.
agent added 1 commit 2026-09-04 07:05:59 +02:00
fleetd #296: close panes on failed spawn
CI / contract (pull_request) Successful in 1m38s
Details
CI / build (pull_request) Successful in 2m7s
Details
cba516bda4
ltms closed this pull request 2026-09-04 07:10:19 +02:00
Some checks are pending
CI / contract (pull_request) Successful in 1m38s
Details
CI / build (pull_request) Successful in 2m7s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Cannot start until something else lands. The body says what.
 needs-live-proof
Merged and green, but never shown working on the running daemon. Not the same as done.
 ready-to-delegate
Scope, files and acceptance criteria are written. A worker can be briefed from the body alone.
 silent-default
A feature that compiles, passes tests, and ships turned off. Nine recurrences and counting.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent kevin ltms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fleet/fleetd#299
Delete Branch "worker/fix-296-104622-6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?