fleet/fleetd
3
0
Fork 0
Code Issues 73 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fleetd #266: rename SSH agent environment setting #268

Closed
agent wants to merge 0 commits from worker/fleetd-266-sshagent-rename-a014ff-6 into main
pull from: worker/fleetd-266-sshagent-rename-a014ff-6
merge into: fleet:main
Conversation 0 Commits - Files Changed -
agent commented 2026-09-03 15:13:15 +02:00
Member
Copy Link
Copy Source

Implements fleetd #266.

Changes:

  • Renames the setting to memberCredentials.sshAgentEnv with omit/inherit values.
  • Keeps old sshAuthSock and block/allow spellings silent and compatible.
  • Uses sshAgentEnv when both keys are present, including an unrecognised new value.
  • Unknown values normalize to omit, so configuration fails closed.
  • Keeps the full example comment about what omitting SSH_AUTH_SOCK does and does not protect.

Accepted key/value pairs: sshAuthSock:block, sshAuthSock:allow, sshAuthSock:omit, sshAuthSock:inherit, sshAgentEnv:block, sshAgentEnv:allow, sshAgentEnv:omit, sshAgentEnv:inherit.

Tests:

  • Mutation proof: removed the read-both shim and ran FleetConfigTest#sshAgentEnvAcceptsBothKeysWithBothValueSpellings. It failed: expected but was for sshAuthSock: allow. Restored the shim. git diff --exit-code was clean after the commit.
  • cd fleetd && mvn clean install: Tests run: 1267, Failures: 0, Errors: 0, Skipped: 0; BUILD SUCCESS.
Implements fleetd #266. Changes: - Renames the setting to memberCredentials.sshAgentEnv with omit/inherit values. - Keeps old sshAuthSock and block/allow spellings silent and compatible. - Uses sshAgentEnv when both keys are present, including an unrecognised new value. - Unknown values normalize to omit, so configuration fails closed. - Keeps the full example comment about what omitting SSH_AUTH_SOCK does and does not protect. Accepted key/value pairs: sshAuthSock:block, sshAuthSock:allow, sshAuthSock:omit, sshAuthSock:inherit, sshAgentEnv:block, sshAgentEnv:allow, sshAgentEnv:omit, sshAgentEnv:inherit. Tests: - Mutation proof: removed the read-both shim and ran FleetConfigTest#sshAgentEnvAcceptsBothKeysWithBothValueSpellings. It failed: expected <inherit> but was <omit> for sshAuthSock: allow. Restored the shim. git diff --exit-code was clean after the commit. - cd fleetd && mvn clean install: Tests run: 1267, Failures: 0, Errors: 0, Skipped: 0; BUILD SUCCESS.
agent added 1 commit 2026-09-03 15:13:15 +02:00
fleetd #266: rename SSH agent environment setting
CI / contract (pull_request) Successful in 1m29s
Details
CI / build (pull_request) Successful in 2m1s
Details
d42c2bc204
ltms closed this pull request 2026-09-04 03:26:38 +02:00
Some checks are pending
CI / contract (pull_request) Successful in 1m29s
Details
CI / build (pull_request) Successful in 2m1s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Cannot start until something else lands. The body says what.
 needs-live-proof
Merged and green, but never shown working on the running daemon. Not the same as done.
 ready-to-delegate
Scope, files and acceptance criteria are written. A worker can be briefed from the body alone.
 silent-default
A feature that compiles, passes tests, and ships turned off. Nine recurrences and counting.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent kevin ltms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fleet/fleetd#268
Delete Branch "worker/fleetd-266-sshagent-rename-a014ff-6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?