fleet/fleetd
3
0
Fork 0
Code Issues 73 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

CB-612: suppress unneeded token warnings #235

Merged
ltms merged 2 commits from worker/cb115-startup-warning-85c539-2 into main 2026-09-03 05:02:27 +02:00
Conversation 0 Commits 2 Files Changed 5
+87 -10
agent commented 2026-09-03 04:51:17 +02:00
Member
Copy Link
Copy Source

CB-612

Suppresses the old implicit worker-token warning for non-subscription profiles that do not configure tokenEnv.

  • Empty or missing tokenEnv now means the profile does not require a token.
  • Claude Code resolves tokenEnv through the null-safe launcher helper, so a tokenless direct profile can still spawn and has no ANTHROPIC_AUTH_TOKEN injected.
  • Added log tests for explicit token requirements and tokenless profiles, plus a Claude Code spawn regression test.

tokenEnv reader audit

  • ClaudeCodeLauncher: fixed; now uses resolveEnv for a null tokenEnv.
  • OpenCodeLauncher: already uses resolveEnv, so null is safe.
  • ConfigRef: already compares tokenEnv with Objects.equals, so null is safe.
  • MemberEnvAllowList: addIfPresent ignores null and blank names.

OpenCode still requires an explicit tokenEnv for every profile kind by design.

Checks

  • Mutation proof: restoring the old default made the no-warning test fail (expected: <true> but was: <false>).
  • Pre-fix Claude Code regression test failed with NullPointerException; it now passes.
  • mvn clean install: Tests run: 1125, Failures: 0, Errors: 0, Skipped: 0; BUILD SUCCESS.

Live daemon startup was not checked because this worker must not restart fleetd.

## CB-612 Suppresses the old implicit worker-token warning for non-subscription profiles that do not configure `tokenEnv`. - Empty or missing `tokenEnv` now means the profile does not require a token. - Claude Code resolves `tokenEnv` through the null-safe launcher helper, so a tokenless direct profile can still spawn and has no `ANTHROPIC_AUTH_TOKEN` injected. - Added log tests for explicit token requirements and tokenless profiles, plus a Claude Code spawn regression test. ### tokenEnv reader audit - `ClaudeCodeLauncher`: fixed; now uses `resolveEnv` for a null `tokenEnv`. - `OpenCodeLauncher`: already uses `resolveEnv`, so null is safe. - `ConfigRef`: already compares `tokenEnv` with `Objects.equals`, so null is safe. - `MemberEnvAllowList`: `addIfPresent` ignores null and blank names. OpenCode still requires an explicit `tokenEnv` for every profile kind by design. ### Checks - Mutation proof: restoring the old default made the no-warning test fail (`expected: <true> but was: <false>`). - Pre-fix Claude Code regression test failed with `NullPointerException`; it now passes. - `mvn clean install`: `Tests run: 1125, Failures: 0, Errors: 0, Skipped: 0`; `BUILD SUCCESS`. Live daemon startup was not checked because this worker must not restart fleetd.
agent added 1 commit 2026-09-03 04:51:18 +02:00
CB-612: suppress unneeded token warnings
CI / contract (pull_request) Successful in 1m7s
Details
CI / build (pull_request) Successful in 1m17s
Details
723fe494e9
agent added 1 commit 2026-09-03 04:59:34 +02:00
CB-612: support tokenless Claude Code profiles
CI / contract (pull_request) Successful in 1m4s
Details
CI / build (pull_request) Successful in 1m24s
Details
adb7a67880
ltms merged commit 1c051c4e47 into main 2026-09-03 05:02:27 +02:00
ltms deleted branch worker/cb115-startup-warning-85c539-2 2026-09-03 05:02:27 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Cannot start until something else lands. The body says what.
 needs-live-proof
Merged and green, but never shown working on the running daemon. Not the same as done.
 ready-to-delegate
Scope, files and acceptance criteria are written. A worker can be briefed from the body alone.
 silent-default
A feature that compiles, passes tests, and ships turned off. Nine recurrences and counting.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent kevin ltms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fleet/fleetd#235
Delete Branch "worker/cb115-startup-warning-85c539-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?