• Joined on 2026-03-08
ltms commented on issue fleet/fleetd#571 2026-09-12 14:08:33 +02:00
MessageService collapses the new ATTEMPTED state into TIMED_OUT_QUEUED, so a possibly-delivered message is reported as one that will never arrive

Unblocked — #551 merged as 384867d (PR #569).

Decision: option 1. Add a fourth outcome.

I made the design call myself rather than delegate it, and I measured the thing the ticket said would…

ltms commented on issue fleet/fleetd#575 2026-09-12 14:06:21 +02:00
The waiter cleanup in MessageService is maintained at three sites, and one of them is outside any finally

Fixed and merged to main as 204da67 (change b091c51, PR #576).

The ticket's fallback case is what happened. I asked for the two reachability questions to be answered before anyone…

ltms closed pull request fleet/fleetd#576 2026-09-12 14:06:05 +02:00
fleetd #575: widen answer()'s try so one finally covers its STALE_TURN exit
ltms commented on pull request fleet/fleetd#576 2026-09-12 14:05:59 +02:00
fleetd #575: widen answer()'s try so one finally covers its STALE_TURN exit

Merged to main as 204da67 (merge commit; the change itself is b091c51). Closing this PR by hand — the merge was done locally and pushed.

What I checked myself, not taken from the…

ltms pushed to main at fleet/fleetd 2026-09-12 14:05:24 +02:00
204da67d66 Merge #576: fleetd #575 — one finally covers answer()'s STALE_TURN exit
b091c51eee fleetd #575: widen answer()'s try so one finally covers its STALE_TURN exit
Compare 2 commits »
ltms closed issue fleet/fleetd#575 2026-09-12 14:05:24 +02:00
The waiter cleanup in MessageService is maintained at three sites, and one of them is outside any finally
ltms opened issue fleet/fleetd#575 2026-09-12 13:31:12 +02:00
The waiter cleanup in MessageService is maintained at three sites, and one of them is outside any finally
ltms pushed to main at fleet/fleetd 2026-09-12 13:30:24 +02:00
84d631b030 Merge #572: answer()'s session-lock release is pinned on all four exits
a4dbc8f8b7 fleetd #572: pin answer()'s session-lock release across all four exits
Compare 2 commits »
ltms merged pull request fleet/fleetd#574 2026-09-12 13:30:23 +02:00
fleetd #572: pin answer()'s session-lock release across all four exits
ltms closed issue fleet/fleetd#567 2026-09-12 13:26:36 +02:00
LeadMailbox.inspect leaks a probe channel if the close is removed, and 15 contract tests stay green while the line runs 3 times
ltms pushed to main at fleet/fleetd 2026-09-12 13:26:33 +02:00
3f8c38fc54 Merge #567: pin LeadMailbox.inspect's probe-channel close
5441a2b321 fleetd #567: assert inspect closes probe channel
Compare 2 commits »
ltms merged pull request fleet/fleetd#573 2026-09-12 13:26:31 +02:00
fleetd #567: assert inspect closes probe channel
ltms commented on issue fleet/fleetd#561 2026-09-12 13:22:59 +02:00
Fleetd's TurnListener.onDelivered ordering is load-bearing and untested: swapping two lines makes a throw strand the caller for its full timeout

Merged as ed2fd66 (PR #570).

Lead verification on a merged tree, re-running everything rather than accepting the worker's numbers: mvn -o clean install from fleetd/, exit 0, 1761 tests…

ltms commented on issue fleet/fleetd#551 2026-09-12 13:22:03 +02:00
Injector records the delivery AFTER the irreversible send, so a failure in the response window marks a delivered brief NOT_DELIVERED

Merged as 384867d (PR #569).

Verified by the lead on a merged tree, re-running the checks rather than accepting the worker's:

  • mvn -o clean install from fleetd/, exit 0. 1754 tests…
ltms pushed to main at fleet/fleetd 2026-09-12 13:20:58 +02:00
ed2fd6646a Merge #561: the completion/session listener fan-out survives either half throwing, and both sites are pinned
034e17bb32 fleetd #561 follow-up: pin the session half of bothMustRunKeepingSecondResult
e20ccab1eb fleetd #561: harden the completion/session TurnListener fan-out
Compare 3 commits »
ltms merged pull request fleet/fleetd#570 2026-09-12 13:20:56 +02:00
fleetd #561: harden the completion/session TurnListener fan-out
ltms pushed to main at fleet/fleetd 2026-09-12 13:19:22 +02:00
384867dfa3 Merge #551: ATTEMPTED is its own cancellation answer, and the javadoc stops claiming a timed-out send never arrived
f40c19ecf0 fleetd #551 shape sweep: fix stale ATTEMPTED-route javadoc/comments in MessageService
68b428c484 fleetd #551 rework (comment 17058): fix TIMED_OUT_QUEUED javadoc for ATTEMPTED
d83821bbce fleetd #551: record the delivery attempt before the irreversible send
Compare 4 commits »
ltms closed issue fleet/fleetd#551 2026-09-12 13:19:20 +02:00
Injector records the delivery AFTER the irreversible send, so a failure in the response window marks a delivered brief NOT_DELIVERED
ltms merged pull request fleet/fleetd#569 2026-09-12 13:19:20 +02:00
fleetd #551: record the delivery attempt before the irreversible send
ltms commented on issue fleet/fleetd#572 2026-09-12 13:13:43 +02:00
MessageService.answer() can lose its session-lock release and the whole suite stays green

Evidence for the "covered, not uncovered" half of the claim, since a surviving mutation has three possible causes and only one of them is this one.

A surviving mutation means the line never…