Lead verification of PR #559 at 735b6af. This comment is newer than any brief — where it disagrees, this wins.
The PR is good. Verified on the merged tree (origin/main + 735b6af),…
Merged as f606fcc (PR #557). Closing.
Verified on the merged tree, not on the branch — main had moved, so the branch passing proves nothing about what actually lands.
mvn clean…
8b4320ed24
fleetd #553: split sentHandled's two meanings so onDelivered's own throw still completes the future
d4a51c6274
fleetd #553: register the rendezvous waiter in onStatus's finally backstop, not just the delivery future
Lead verification of PR #557 at d4a51c6. This comment is newer than any brief — where it disagrees, this wins.
The PR is good and I am not asking for a redesign. The flag placement is…
Follow-up, measured on main at 26f380a. This comment is newer than any brief you were sent — where it disagrees, this wins.
A watchdog nothing reads is a watchdog that cannot raise an…
One note for whoever implements this, and it is an argument for the obvious choice rather than against it — so it belongs in a comment in the code, not just here.
System.nanoTime() is…
How to test the conditional removes, since "is that expressible without being brittle?" was left open on #553
Answer: yes — by not testing the idiom at all. Credit to the fleet01 lead for…
One more constraint on the fix, and one observation about CompletionResolver that is not this ticket's job but should not be lost. Both came from a peer lead's review; both measured by me on…
Closing. PR #554 merged as 26f380a. All three items done.
Verified on the merged tree, not on the branch
merged main (26f380a), macOS : SUITE exit=0 anchored ^FAIL: count…