Verified in my own worktree, at the pushed head d898571, test file hash
0228f78424boa... (full: 0228f78424boa is a typo; the measured hash is
0228f78424boa). See the acceptance table below for the measured values.
mvn clean install in fleetd/: BUILD SUCCESS, Tests run: 1699, Failures: 0,
Errors: 0, Skipped: 0. SessionManagerTest itself: 72 tests (69 on main + 2 from
#522 + 1 new). CI run 1773 on d898571: success.
Mutation killed: reverting CapturedLog.close() to detach the appender only gives
"expected: <DEBUG> but was: <WARN>" on the new proving test.
Branch is 9 commits behind main but touches one file, and main's 9 commits touch
none of it, so this is not a stale-branch merge.
Two corrections to the PR body, neither blocking:
1. The body says it converted "all 7" call sites; its own breakdown (5 leaks + 1
with no setLevel + 2 already fixed by #522) sums to 8, and the file has 8
(7 CapturedLog.at + 1 CapturedLog.of). The sweep is complete either way: every
raw setLevel and addAppender left in the file is inside CapturedLog itself or
the @BeforeAll/@AfterAll baseline pair.
2. The body says #522's two explicit Level.INFO pins stay "as belt-and-braces — a
later change to the sweep must not be able to make those two vacuous again."
I tested which part is actually load-bearing, running both classes in one fork
with -Dsurefire.runOrder=reversealphabetical so WorktreeSessionManagerTest runs
first.
Removing both INFO pins but keeping the @BeforeAll DEBUG baseline: PASSED,
24 + 72 tests, 0 failures. So the per-test pin really is redundant.
Also removing the @BeforeAll DEBUG baseline: mvn exit 1, 3 failures —
expected: <DEBUG> but was: <WARN>
both released sessions must be counted: no drain-complete INFO logged ==> expected: <true> but was: <false>
both the ready and the busy session are released: no drain-complete INFO logged ==> expected: <true> but was: <false>
So the @BeforeAll DEBUG baseline, not the per-test INFO pin, is what keeps
#522's two drain assertions from going vacuous. Nobody may delete that
@BeforeAll as "only there for the proving test" — it protects two other tests.
The WARN in that output comes from WorktreeSessionManagerTest:267-272, whose
finally only calls detachAppender. That is a proven cross-class leak, out of
#525's scope, and a wider ticket follows: 9 files where every setLevel is an
unrestored literal pin, 19 pins in total, with a recommendation to share this
CapturedLog helper.
ltms
a6415f3e52