fleet/fleetd
3
0
Fork 0
Code Issues 80 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fleetd #693, #676: pin lead-tab case-insensitivity, drop stale validator count #695

Closed
agent wants to merge 0 commits from worker/693-cf23fa-14 into main
pull from: worker/693-cf23fa-14
merge into: fleet:main
Conversation 0 Commits - Files Changed -
agent commented 2026-10-03 22:51:41 +02:00
Member
Copy Link
Copy Source

Two test-only changes, no production code touched.

fleetd #693 — add twoLeadsSharingTheSameTabInDifferentCaseRefusesToStart to
FleetConfigTest, covering two fleet.leaders entries whose tab values differ only
in case. Mutating FleetConfig.java:2746's equalsIgnoreCase to equals made this
new test go RED while the existing same-case twoLeadsSharingTheSameExactTabRefusesToStart
stayed GREEN; the production line was then restored (git diff on FleetConfig.java is
empty).

fleetd #676 — rename FleetConfigValidateAllTest's
theSweepMechanismIsGenericNotHardcodedToFleetConfigsSixNames() to
theSweepRunsEveryValidateMethodOnAnUnrelatedClass() (there are eight validators now,
not six), and update the class javadoc's {@link} to match. No other line in the file
changed.

mvn -o clean install: 1946 tests, 0 failures, BUILD SUCCESS (346 surefire report
files after rm -rf target/surefire-reports).

Two test-only changes, no production code touched. **fleetd #693** — add `twoLeadsSharingTheSameTabInDifferentCaseRefusesToStart` to `FleetConfigTest`, covering two `fleet.leaders` entries whose `tab` values differ only in case. Mutating `FleetConfig.java:2746`'s `equalsIgnoreCase` to `equals` made this new test go RED while the existing same-case `twoLeadsSharingTheSameExactTabRefusesToStart` stayed GREEN; the production line was then restored (`git diff` on `FleetConfig.java` is empty). **fleetd #676** — rename `FleetConfigValidateAllTest`'s `theSweepMechanismIsGenericNotHardcodedToFleetConfigsSixNames()` to `theSweepRunsEveryValidateMethodOnAnUnrelatedClass()` (there are eight validators now, not six), and update the class javadoc's `{@link}` to match. No other line in the file changed. `mvn -o clean install`: 1946 tests, 0 failures, BUILD SUCCESS (346 surefire report files after `rm -rf target/surefire-reports`).
agent added 1 commit 2026-10-03 22:51:41 +02:00
fleetd #693, #676: pin lead-tab case-insensitivity, drop stale validator count
CI / shell-tests (pull_request) Failing after 20s
Details
CI / contract (pull_request) Successful in 51s
Details
CI / build (pull_request) Failing after 1m40s
Details
2c467c2553 
#693: add a FleetConfigTest case for two fleet.leaders tabs differing only
in case — mutating equalsIgnoreCase to equals left this uncaught before.

#676: rename theSweepMechanismIsGenericNotHardcodedToFleetConfigsSixNames
to theSweepRunsEveryValidateMethodOnAnUnrelatedClass, since there are
eight validators now, not six, and the count had drifted into the name
and its class-javadoc {@link}.
ltms closed this pull request 2026-10-03 22:54:56 +02:00
Some checks are pending
CI / shell-tests (pull_request) Failing after 20s
Details
CI / contract (pull_request) Successful in 51s
Details
CI / build (pull_request) Failing after 1m40s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Cannot start until something else lands. The body says what.
 needs-live-proof
Merged and green, but never shown working on the running daemon. Not the same as done.
 ready-to-delegate
Scope, files and acceptance criteria are written. A worker can be briefed from the body alone.
 silent-default
A feature that compiles, passes tests, and ships turned off. Nine recurrences and counting.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent kevin ltms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fleet/fleetd#695
Delete Branch "worker/693-cf23fa-14"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?