fleetd #618: state the measured auto-compact precedence #619

Merged

ltms merged 2 commits from worker/618-b83894-2 into main 2026-09-22 05:53:36 +02:00

Conversation 0 Commits 2 Files Changed 2

+18 -14

agent commented 2026-09-22 05:46:54 +02:00

Member

Copy Link

Copy Source

Closes the two spots in code that claimed the precedence between --autocompact and CLAUDE_CODE_AUTO_COMPACT_WINDOW was unverified. fleetd #618 measured it: the env var wins.

• ClaudeCodeArguments.withAutoCompactWindow javadoc now states the measured precedence, names #618, and says the flag has NO effect when the env var is also set (measured against Claude Code 2.1.278).
• FleetConfig.warnConflictingAutoCompactWindows' WARN text now says the env var wins, autoCompactWindow is inert on the conflicting profile, and that deleting the env var to resolve the conflict LOWERS the live window rather than fixing anything. Still a WARN, same trigger condition, no behaviour change (per #601, kept as WARN not throw).

Text-only change. mvn clean install: Tests run: 1877, Failures: 0, Errors: 0, Skipped: 0 -- BUILD SUCCESS.

Closes the two spots in code that claimed the precedence between --autocompact and CLAUDE_CODE_AUTO_COMPACT_WINDOW was unverified. fleetd #618 measured it: the env var wins. - ClaudeCodeArguments.withAutoCompactWindow javadoc now states the measured precedence, names #618, and says the flag has NO effect when the env var is also set (measured against Claude Code 2.1.278). - FleetConfig.warnConflictingAutoCompactWindows' WARN text now says the env var wins, autoCompactWindow is inert on the conflicting profile, and that deleting the env var to resolve the conflict LOWERS the live window rather than fixing anything. Still a WARN, same trigger condition, no behaviour change (per #601, kept as WARN not throw). Text-only change. mvn clean install: Tests run: 1877, Failures: 0, Errors: 0, Skipped: 0 -- BUILD SUCCESS.

agent added 1 commit 2026-09-22 05:46:54 +02:00

fleetd #618: state the measured auto-compact precedence, not 'unverified' ... 8368a274a0

ClaudeCodeArguments.withAutoCompactWindow's javadoc and FleetConfig's
warnConflictingAutoCompactWindows WARN text both used to say the
precedence between --autocompact and CLAUDE_CODE_AUTO_COMPACT_WINDOW was
not verified. fleetd #618 measured it: the env var wins, so the flag has
no effect when both are set. Update both texts to say so, name #618, and
warn that deleting the env var to resolve the conflict LOWERS the live
window rather than fixing anything. No behaviour change; the WARN still
fires on the same condition and stays a WARN (per #601).

ltms referenced this pull request 2026-09-22 05:48:16 +02:00

Measured: CLAUDE_CODE_AUTO_COMPACT_WINDOW beats --autocompact, so fleetd.yaml's comment is backwards #618

agent added 1 commit 2026-09-22 05:51:06 +02:00

fleetd #618: fix the third stale spot the brief missed ... 6cb31a10e4

The method-level javadoc on FleetConfig.warnConflictingAutoCompactWindows
(above the log.warn call) still claimed the autoCompactWindow vs
CLAUDE_CODE_AUTO_COMPACT_WINDOW precedence was 'intentionally not
asserted' and cited fleetd.yaml's now-corrected comment as evidence the
question was open. Replace it with the measured answer from #618: the
env var wins, so autoCompactWindow is inert on a profile that sets both.
Kept the WARN-not-throw rationale paragraph above it untouched (#601)
and kept the ClaudeCodeArguments cross-reference, which now points to an
agreeing claim instead of a contradicting one. No behaviour change.

ltms merged commit 8915e40c7d into main 2026-09-22 05:53:36 +02:00

ltms referenced this pull request 2026-09-22 05:54:02 +02:00

Measured: CLAUDE_CODE_AUTO_COMPACT_WINDOW beats --autocompact, so fleetd.yaml's comment is backwards #618

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

blocked

Cannot start until something else lands. The body says what.

needs-live-proof

Merged and green, but never shown working on the running daemon. Not the same as done.

ready-to-delegate

Scope, files and acceptance criteria are written. A worker can be briefed from the body alone.

silent-default

A feature that compiles, passes tests, and ships turned off. Nine recurrences and counting.

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent kevin ltms

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: fleet/fleetd#619