fleet/fleetd
3
0
Fork 0
Code Issues 73 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

#281: pin handler authorization actions #286

Closed
agent wants to merge 0 commits from worker/fix-281-pin-handler-actions-4921ac-7 into main
pull from: worker/fix-281-pin-handler-actions-4921ac-7
merge into: fleet:main
Conversation 0 Commits - Files Changed -
agent commented 2026-09-04 05:42:01 +02:00
Member
Copy Link
Copy Source

Fixes #281.

Uses source-text registration scrapes, following McpContractDocTest. The MCP test reads tool("fleet_…") calls. The REST test reads app.("…") calls. Both have denominator guards. GET /healthz is an explicit open liveness exception.

Property 1 mutation: changing fleet_poll target handling to READ failed FleetMcpAuthzTest with expected: <DRAIN> but was: <READ>.

Property 2 MCP mutation: I added a registered fleet_fake tool that called deny(..., READ, ...) directly. The test failed: fleet_fake is registered but has no pinned authorization action ==> Unexpected exception thrown: java.lang.IllegalArgumentException: unregistered tool: fleet_fake.

Property 2 REST mutation: I added GET /fake that called allow(..., READ, ...) directly. The test failed: GET /fake is registered but has no pinned authorization action ==> Unexpected exception thrown: java.lang.IllegalArgumentException: route has no authorization gate: GET /fake.

Check run: cd fleetd && mvn clean install — Tests run: 1285, Failures: 0, Errors: 0, Skipped: 0; BUILD SUCCESS.

Fixes #281. Uses source-text registration scrapes, following McpContractDocTest. The MCP test reads tool("fleet_…") calls. The REST test reads app.<verb>("…") calls. Both have denominator guards. GET /healthz is an explicit open liveness exception. Property 1 mutation: changing fleet_poll target handling to READ failed FleetMcpAuthzTest with `expected: <DRAIN> but was: <READ>`. Property 2 MCP mutation: I added a registered fleet_fake tool that called deny(..., READ, ...) directly. The test failed: `fleet_fake is registered but has no pinned authorization action ==> Unexpected exception thrown: java.lang.IllegalArgumentException: unregistered tool: fleet_fake`. Property 2 REST mutation: I added GET /fake that called allow(..., READ, ...) directly. The test failed: `GET /fake is registered but has no pinned authorization action ==> Unexpected exception thrown: java.lang.IllegalArgumentException: route has no authorization gate: GET /fake`. Check run: `cd fleetd && mvn clean install` — `Tests run: 1285, Failures: 0, Errors: 0, Skipped: 0`; `BUILD SUCCESS`.
agent added 1 commit 2026-09-04 05:42:01 +02:00
wip: pin handler authorization actions
CI / build (pull_request) Successful in 1m30s
Details
CI / contract (pull_request) Successful in 2m27s
Details
719b79f892
agent added 1 commit 2026-09-04 05:49:05 +02:00
#281: cover registered authorization actions
CI / contract (pull_request) Successful in 1m14s
Details
CI / build (pull_request) Successful in 1m33s
Details
30e21adec7
ltms closed this pull request 2026-09-04 05:53:07 +02:00
Some checks are pending
CI / contract (pull_request) Successful in 1m14s
Details
CI / build (pull_request) Successful in 1m33s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Cannot start until something else lands. The body says what.
 needs-live-proof
Merged and green, but never shown working on the running daemon. Not the same as done.
 ready-to-delegate
Scope, files and acceptance criteria are written. A worker can be briefed from the body alone.
 silent-default
A feature that compiles, passes tests, and ships turned off. Nine recurrences and counting.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent kevin ltms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fleet/fleetd#286
Delete Branch "worker/fix-281-pin-handler-actions-4921ac-7"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?