From f8b0d42a5cb63e6c449c41c0f5047e2c8c64e701 Mon Sep 17 00:00:00 2001
From: Dai Ha <dai.ha@magnolia-cms.com>
Date: Thu, 10 Sep 2026 13:25:19 +0700
Subject: [PATCH] fleetd #431 follow-up: profileForSlot's javadoc named a
 caller that does not exist
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The javadoc said "what the spawn lifecycle reads". Nothing in src/main calls
profileForSlot at all, in either the ".profileForSlot(" or the
"::profileForSlot" form. My own #431 ticket text repeated that sentence as a
fact and ranked the three accessors by it, and the #432 worker copied it into
the test file's comment and one assertion message. Corrected in all three
places; the ticket correction is posted on #431.

What the spawn lifecycle actually reads for an architect's profile is the
SlotReservation that reserve() returns — SessionManager.java:225,
"reservation == null ? profile : reservation.profile()".

The corrected ranking, measured rather than read off the javadoc:
- nameForSlot is wired, at CallerResolver.java:137 (method reference, which is
  why a ".nameForSlot(" grep missed it)
- isSlot is reached through bind, called at MemberRegistry.java:235 and :376
- profileForSlot has no caller at all

Prose only. No behaviour change.
---
 .../dev/ltms/fleet/auth/MemberRegistry.java     | 10 +++++++++-
 .../ltms/fleet/auth/MemberRegistryLiveTest.java | 17 +++++++++++------
 2 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/fleetd/src/main/java/dev/ltms/fleet/auth/MemberRegistry.java b/fleetd/src/main/java/dev/ltms/fleet/auth/MemberRegistry.java
index 3007842..5adb19e 100644
--- a/fleetd/src/main/java/dev/ltms/fleet/auth/MemberRegistry.java
+++ b/fleetd/src/main/java/dev/ltms/fleet/auth/MemberRegistry.java
@@ -177,7 +177,15 @@ public final class MemberRegistry implements MemberLifecycle {
     }
 
     /**
-     * The strong-model profile a slot runs under — what the spawn lifecycle reads.
+     * The strong-model profile a slot runs under, as of this call.
+     *
+     * <p>Nothing in {@code src/main} calls this (fleetd #431 — grepped both the {@code
+     * .profileForSlot(} and the {@code ::profileForSlot} form). This javadoc used to say "what the
+     * spawn lifecycle reads", and that seam does not exist: the spawn lifecycle takes its profile
+     * from the {@link MemberLifecycle.SlotReservation} that {@code reserve} returns, never from
+     * here. Kept and pinned rather than deleted because it is the natural accessor for that seam
+     * if one is added; live for the same reason as {@link #roleForSlot}, so a reload cannot leave
+     * it answering for the old config.
      *
      * @return the slot's configured {@code profile}, or {@code null} if the slot is unknown or
      *         declares none
diff --git a/fleetd/src/test/java/dev/ltms/fleet/auth/MemberRegistryLiveTest.java b/fleetd/src/test/java/dev/ltms/fleet/auth/MemberRegistryLiveTest.java
index fde51aa..5ca1904 100644
--- a/fleetd/src/test/java/dev/ltms/fleet/auth/MemberRegistryLiveTest.java
+++ b/fleetd/src/test/java/dev/ltms/fleet/auth/MemberRegistryLiveTest.java
@@ -174,10 +174,16 @@ class MemberRegistryLiveTest {
     // ── profileForSlot, isSlot and nameForSlot are live too (fleetd #431) ─────────────────────────
     // #424 pinned roleForSlot against a live reload but left these three untested — proved by
     // mutating each to read a snapshot flattened once at construction: the full suite stayed green
-    // for all three. profileForSlot is the one with a real production stake: the spawn lifecycle
-    // reads it to pick an architect slot's backend, and fleetd has no call site for it yet (grepped
-    // "profileForSlot" across src/main — only this file and MemberRegistryTest reference it), so
-    // there is no seam to drive this test through beyond the accessor itself.
+    // for all three.
+    //
+    // The three differ in how much production behaviour depends on them, and the ticket first got
+    // this ranking wrong. nameForSlot is wired: CallerResolver passes members::nameForSlot, next to
+    // members::roleForSlot. isSlot is reached through bind, which calls it to refuse an unknown
+    // slot. profileForSlot has NO caller in src/main at all — grepped both the ".profileForSlot("
+    // and the "::profileForSlot" form — so there is no seam to drive its test through beyond the
+    // accessor itself, and its own javadoc ("what the spawn lifecycle reads") describes a caller
+    // that does not exist. These tests pin the accessors as they are; whether profileForSlot should
+    // be wired or deleted is a separate question.
 
     @Test
     void profileForSlotReflectsAProfileChangedByReload(@TempDir Path dir) throws Exception {
@@ -194,8 +200,7 @@ class MemberRegistryLiveTest {
         assertTrue(out.applied(), "the reload must actually take effect: " + out.summary());
 
         assertEquals("opus", registry.profileForSlot("architect:designer"),
-                "repointing the slot to a different profile must take effect with no restart — "
-                        + "this is what the spawn lifecycle reads to pick an architect's backend");
+                "repointing the slot to a different profile must take effect with no restart");
     }
 
     @Test