fleet/fleetd
3
0
Fork 0
Code Issues 79 Pull Requests 5 Actions Packages Projects Releases 1 Wiki Activity

fleetd #663: remove the dead legacy assertion review flagged on PR 665
CI / shell-tests (pull_request) Failing after 9s
Details
CI / contract (pull_request) Successful in 57s
Details
CI / build (pull_request) Failing after 2m6s
Details

Browse Source 
noEffectiveWindowFallsBackToTheFixed200000Default's third assertion
(legacyConfigDir/legacyGauge) used to call the 3-arg read() to prove
it behaved like a null window. With the 3-arg form gone, it is the
same call, same input (200_000) and same expectation as the atGauge
assertion above it, so it cannot fail unless that one already failed,
and its message named a method that no longer exists. Deleted it; the
first two assertions (199_999 -> OK, 200_000 -> HIGH) are unchanged.
This commit is contained in:
Dai Ha
2026-10-03 19:34:47 +02:00
parent a52ca35d34
commit 60fa86a107
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fleetd/src/test/java/dev/ltms/fleet/lead/LeadContextGaugeHighThresholdTest.java
-6
View File
@@ -81,12 +81,6 @@ class LeadContextGaugeHighThresholdTest {
assertEquals(LeadContextGauge.State.HIGH, assertEquals(LeadContextGauge.State.HIGH,
atGauge.read(atConfigDir, SESSION_ID, "claude", null).state(), atGauge.read(atConfigDir, SESSION_ID, "claude", null).state(),
"the fixed default must still be 200,000 when no window is resolvable"); "the fixed default must still be 200,000 when no window is resolvable");
String legacyConfigDir = writeTranscript(tmp.resolve("legacy"), SESSION_ID, 200_000);
LeadContextGauge legacyGauge = new LeadContextGauge();
assertEquals(LeadContextGauge.State.HIGH,
legacyGauge.read(legacyConfigDir, SESSION_ID, "claude", null).state(),
"the 3-arg read() (no window argument at all) must behave exactly like passing a null window");
} }
@Test @Test